Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get correct docker tags for everything #281

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Get correct docker tags for everything #281

merged 1 commit into from
Oct 6, 2023

Conversation

curtbushko
Copy link
Contributor

Bringing over #271

@curtbushko curtbushko requested review from a team, dekimsey, jeanneryan and wilkermichael and removed request for a team October 6, 2023 19:46
@curtbushko curtbushko added pr/no-changelog This PR does not introduce a user-facing change that should be reflected in the changelog backport/1.1 Changes are backported to 1.1 backport/1.2 labels Oct 6, 2023
wilkermichael
wilkermichael approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@wilkermichael wilkermichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this over!

@curtbushko curtbushko merged commit c5c3248 into main Oct 6, 2023
39 of 40 checks passed
@curtbushko curtbushko deleted the fix-rc-docker-image-name branch October 6, 2023 20:18
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Oct 6, 2023
Closed
@curtbushko curtbushko added backport/1.1 Changes are backported to 1.1 backport/1.2 and removed backport/1.1 Changes are backported to 1.1 backport/1.2 labels Oct 7, 2023
This was referenced Oct 7, 2023
Closed
Closed
@curtbushko curtbushko removed backport/1.1 Changes are backported to 1.1 backport/1.2 labels Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkermichael wilkermichael wilkermichael approved these changes

@dekimsey dekimsey Awaiting requested review from dekimsey

@jeanneryan jeanneryan Awaiting requested review from jeanneryan

Assignees
No one assigned
Labels
pr/no-changelog This PR does not introduce a user-facing change that should be reflected in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curtbushko @wilkermichael