Post-release updates for v1.6.0 #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nathancoleman
commented
Oct 15, 2024
nathancoleman
commented
- Port over CHANGELOG update
- Consume latest release of consul/proto-public
Fix typo in changelog header
nathancoleman
requested review from
jm96441n,
NiniOak,
sarahalsmiller and
xwa153
nathancoleman
added
the
pr/no-changelog
zalimeni
reviewed
Oct 16, 2024
Comment on lines
+32
to
+33
| * Upgrade envoy version to 1.31.2 to address [CVE-2024-45807](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-45807),[CVE-2024-45808](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-45808),[CVE-2024-45806](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-45806),[CVE-2024-45809](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-45809) and [CVE-2024-45810](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-45810) [[GH-624](https://github.com/hashicorp/consul-dataplane/pull/624)] | ||
| * Upgrade to support Envoy `1.31.0`. [[GH-609](https://github.com/hashicorp/consul-dataplane/pull/609)] |
There was a problem hiding this comment.
Suggested change
| * Upgrade envoy version to 1.31.2 to address [CVE-2024-45807](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-45807),[CVE-2024-45808](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-45808),[CVE-2024-45806](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-45806),[CVE-2024-45809](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-45809) and [CVE-2024-45810](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-45810) [[GH-624](https://github.com/hashicorp/consul-dataplane/pull/624)] | |
| * Upgrade to support Envoy `1.31.0`. [[GH-609](https://github.com/hashicorp/consul-dataplane/pull/609)] | |
| * Upgrade Envoy version to 1.31.2 to address [CVE-2024-45807](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-45807),[CVE-2024-45808](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-45808),[CVE-2024-45806](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-45806),[CVE-2024-45809](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-45809) and [CVE-2024-45810](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-45810) [[GH-624](https://github.com/hashicorp/consul-dataplane/pull/624)] | |
| * Upgrade to support Envoy 1.31.0. [[GH-609](https://github.com/hashicorp/consul-dataplane/pull/609)] |
~~ Minor, but makes both entries consistent. Could also combine them into one 🤷🏻♂️ but either approach seems valid.
zalimeni
reviewed
Oct 16, 2024
Comment on lines
+39
to
+43
| - DNS Server, xDS Server, and Envoy are enabled. | ||
| - The system validates that `-consul-dns-bind-addr` and equivalent environment variable must be set to the loopback address. | ||
| When set to `dns-proxy`: | ||
| - Only DNS Server is enabled. xDS Server and Envoy are disabled. | ||
| - `consul-dns-bind-addr` and equivalent environment variable can be set to other values besides the loopback address. [[GH-571](https://github.com/hashicorp/consul-dataplane/pull/571)] |
There was a problem hiding this comment.
Suggested change
| - DNS Server, xDS Server, and Envoy are enabled. | |
| - The system validates that `-consul-dns-bind-addr` and equivalent environment variable must be set to the loopback address. | |
| When set to `dns-proxy`: | |
| - Only DNS Server is enabled. xDS Server and Envoy are disabled. | |
| - `consul-dns-bind-addr` and equivalent environment variable can be set to other values besides the loopback address. [[GH-571](https://github.com/hashicorp/consul-dataplane/pull/571)] | |
| - DNS Server, xDS Server, and Envoy are enabled. | |
| - The system validates that `-consul-dns-bind-addr` and equivalent environment variable must be set to the loopback address. | |
| When set to `dns-proxy`: | |
| - Only DNS Server is enabled. xDS Server and Envoy are disabled. | |
| - `consul-dns-bind-addr` and equivalent environment variable can be set to other values besides the loopback address. [[GH-571](https://github.com/hashicorp/consul-dataplane/pull/571)] |
I think this indentation needs fixing for sub-bullets
zalimeni
approved these changes
Oct 16, 2024
|
@nathancoleman oops, I didn't notice auto-merge was on. See prior comments for potential changelog fixes (I can open a PR if you're tied up) |
jm96441n
pushed a commit
that referenced
this pull request
Oct 17, 2024
* Consume latest release of consul/proto-public * Update CHANGELOG.md Fix typo in changelog header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.