acl-controller: Set cross-namespace policy on default namespace #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pglass
requested review from
a team and
erichaberkorn
and removed request for
a team
cthain
reviewed
Jun 8, 2022
| require.NotNil(t, ns.ACLs) | ||
| require.Contains(t, ns.ACLs.PolicyDefaults, xnsLink) | ||
| } else if ns.ACLs != nil { | ||
| // namespaces outside the controller's assigned partition should not have the xnsPolicy |
There was a problem hiding this comment.
nit on the comment: This is true for the test, but I think there are operational cases where the xns policy could/will exist in multiple partitions.
cthain
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This updates the acl-controller to set the cross-namespace policy as a default policy on the default namespace.
How I've tested this PR:
How I expect reviewers to test this PR:
👀
Checklist: