Fix namespace reconciliation error #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pglass
force-pushed
the
pglass/fix-empty-ns-error
branch
from
50af51f to
e577e10
Compare
cthain
approved these changes
Jun 9, 2022
controller/controller.go
Outdated
| if err = c.Resources.ReconcileNamespaces(resources); err != nil { | ||
| return fmt.Errorf("reconciling namespaces: %w", err) | ||
| c.Log.Error("error reconciling namespaces", "err", err) |
There was a problem hiding this comment.
I'm wondering if the log messages here are necessary since there is also a log message in ctrl.reconcile() 🤔 ?.. Any errors here will get logged twice.
There was a problem hiding this comment.
I guess I was thinking I should log the error immediately, but now that I'm seeing this again, you're right. I'll remove these log lines!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This fixes an error message in the acl-controller where it was attempting to use the empty string for the namespace when creating a namespace. When this error occurred while reconciling namespaces, the controller would abort reconciliation, which means it would not proceed to cleanup ACL tokens.
To address that, this also changes the controller to attempt to reconcile resources even if a namespace reconciliation error occurred.
How I've tested this PR:
Unit tests
How I expect reviewers to test this PR:
👀
Checklist: