Deprecate health-sync command #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ganeshrockz
requested review from
a team and
pglass
and removed request for
a team
Ganeshrockz
temporarily deployed
to
dockerhub/hashicorpdev
GitHub Actions
Inactive
cthain
reviewed
Jul 11, 2023
Ganeshrockz
temporarily deployed
to
dockerhub/hashicorpdev
GitHub Actions
Inactive
|
@cthain Can you approve the PR if there are no more concerns? |
cthain
approved these changes
Jul 12, 2023
pglass
approved these changes
Jul 12, 2023
Ganeshrockz
temporarily deployed
to
dockerhub/hashicorpdev
GitHub Actions
Inactive
Ganeshrockz
temporarily deployed
to
dockerhub/hashicorpdev
GitHub Actions
Inactive
Ganeshrockz
commented
Jul 13, 2023
Ganeshrockz
added a commit
that referenced
this pull request
Aug 21, 2023
#161) * Added support for server discovery, TLS and ACL login (#143) * Added support for server discover, TLS and ACL login * Fix lint * Test fix * Fix config tests * Fix tests * Still fixing tests * Fix tests * Fix tests * Address comments * Added protocol specific TLS configs * Fix tests * Address comments * Ability to register services, gateway and proxy (#144) * Ability to register services, gateway and proxy * Fix lint * Refactor registration logic * Add node meta * Refactor functions * Address comments * Fix unit tests * Set additionalProperties to false for service object * Added ability to generate dataplane configuration (#145) * Added ability to generate dataplane configuration * Remove default configs * Modify approach to use encoding/json * Added ability to sync health checks back to Consul * Fix main * Fix lint * Write dataplane config to shared volume * Fix tests * Check enterprise CI * Fix tests * Fix enterprise tests * Address comments * Refactor task meta * Refactoring tests * Address nit comments * Support to gracefully shutdown control-plane (#147) * Support to gracefully shutdown control-plane * Fix lint * Address comments * Address comments * Add tests * Deprecate mesh-init in favour of control-plane (#148) * Deprecate mesh-init in place of control-plane * Address comments * Controller changes to support new ECS architecture - Part 1 (#150) * Controller changes for agentless * Fix tests * Add node tests * Fix comments * Fix tests * Server watch for agentless (#149) * Server watch implemented * Add tests * Address comments * Added mocks for server connection manager * Deprecate health-sync command (#152) * Deprecated health sync command * Fix tests * Fix lint * Fix lint * Fix tests * Controller changes to support new architecture - Part 2 (#153) * Make controller reconcile services * Fix tests * Fix tests * Fix lint * Fix tests * Fix enterprise tests * Fix tests * Remove dataplane tag * Refactor reconcile services * Address comments * Fix tests * Fix lint * Fix lint * Fix non enterprise tests * Fixing enterprise tests * Still trying to fix enterprise tests :( * Address comments * Fix tests * Fix null ref * Fix comments * Address comments * Rename acl controller * Refactor TLS inputs in ECS_CONFIG_JSON (#154) * Refactor server TLS inputs * Fix tests * Fix merge issues * Miscellaneous changes for dataplane architecture (#156) * Added ability to write CA cert to shared volume * Fix tests * Comments * Address comments * Fix addresses for service and proxy registrations (#157) * Added ability to write CA cert to shared volume * Fix tests * Comments * Pass ReadyBindAddress and Port to dataplane * Address comments * Fix lint * Address comments * Fix lint * Add destinationPeer to upstream config (#159) * Fix clusterARN login meta for EC2 (#158) * Fix clusterARN login meta for EC2 * Address comments * Added go-discover binary to the ECS image (#160) * Added go-discover binary to the ECS image * Bump golang version * Add changelog and make some minor changes * Fix tests * Address comments * Remove breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
health-synccommand since the health sync logic moves into the control plane in the new ECS architecture.How I've tested this PR:
Units tests
How I expect reviewers to test this PR:
Checklist: