Fix envoy graceful shutdown #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ganeshrockz
requested review from
a team and
absolutelightning
and removed request for
a team
absolutelightning
approved these changes
Dec 18, 2023
Ganeshrockz
temporarily deployed
to
dockerhub/hashicorpdev
GitHub Actions
Inactive
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
consul-dataplaneto the non app container's map.Typefield to the ECS Task meta response payload.NORMALto facilitate orchestration. Up until now, we were looking into the status of these containers as well to determine if application containers (added by the users) have terminated. This caused issues with graceful shutdown of Consul dataplane and apparently resulted in a forced shutdown of the task.This will also be backported to
release/0.7.xHow I've tested this PR:
CI, Manual deployment
How I expect reviewers to test this PR:
Checklist: