Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add license file #247

Merged
merged 2 commits into from
May 10, 2024
Merged

add license file #247

merged 2 commits into from
May 10, 2024

Conversation

xwa153
Copy link
Member

@xwa153 xwa153 commented May 8, 2024

DoD

  • Add license file into ZIP
  • Add license file into linux config_dir(Not Applicable)
  • Add license file into docker image
  • Add license label into docker image
  • Verify license file is correctly added into various artifacts
  • Support versions: 0.8.1

@xwa153 xwa153 self-assigned this May 8, 2024
@xwa153 xwa153 requested a review from a team May 8, 2024 17:40
@xwa153 xwa153 requested a review from a team as a code owner May 8, 2024 17:40
@xwa153 xwa153 requested review from dekimsey and emilymianeil and removed request for a team May 8, 2024 17:40
@xwa153 xwa153 temporarily deployed to dockerhub/hashicorpdev May 8, 2024 18:50 — with GitHub Actions Inactive
@xwa153 xwa153 force-pushed the xw/NET-9211-add-license branch from 9a3eaa2 to ecbbe0e Compare May 8, 2024 19:20
@xwa153 xwa153 temporarily deployed to dockerhub/hashicorpdev May 8, 2024 19:54 — with GitHub Actions Inactive
@xwa153 xwa153 marked this pull request as draft May 8, 2024 19:59
@xwa153 xwa153 temporarily deployed to dockerhub/hashicorpdev May 8, 2024 20:19 — with GitHub Actions Inactive
@xwa153 xwa153 temporarily deployed to dockerhub/hashicorpdev May 9, 2024 17:21 — with GitHub Actions Inactive
@xwa153 xwa153 force-pushed the xw/NET-9211-add-license branch from dfaef98 to fce8e7d Compare May 9, 2024 21:48
@xwa153 xwa153 marked this pull request as ready for review May 9, 2024 21:48
@xwa153 xwa153 temporarily deployed to dockerhub/hashicorpdev May 9, 2024 22:09 — with GitHub Actions Inactive
zalimeni
zalimeni approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@zalimeni zalimeni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wangxinyi7 ! I'm cutting 0.8.1 probably today - do we need this included in release/0.8.x as well for that release, or is it not a blocker for release?

@xwa153
Copy link
Member Author

xwa153 commented May 10, 2024

Thanks @wangxinyi7 ! I'm cutting 0.8.1 probably today - do we need this included in release/0.8.x as well for that release, or is it not a blocker for release?

Thanks for approving, it's good to get merged in this release cycle, but if it's too urgent, totally ok to skip this time and release in next version, it's not a blocker for sure. @zalimeni

This was referenced May 10, 2024
Closed
Merged
@xwa153 xwa153 temporarily deployed to dockerhub/hashicorpdev May 10, 2024 18:54 — with GitHub Actions Inactive
@xwa153 xwa153 merged commit 79d5980 into main May 10, 2024
27 checks passed
@xwa153 xwa153 deleted the xw/NET-9211-add-license branch May 10, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zalimeni zalimeni zalimeni approved these changes

@dekimsey dekimsey Awaiting requested review from dekimsey

@emilymianeil emilymianeil Awaiting requested review from emilymianeil

Assignees

@xwa153 xwa153

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xwa153 @zalimeni