[NET11250]Added fix for health check update for consul-dataplane #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we update the consul-dataplane health status, we should take into account the service health status as well
abhishek-hashicorp
changed the title
abhishek-hashicorp
temporarily deployed
to
dockerhub/hashicorpdev
GitHub Actions
Inactive
abhishek-hashicorp
temporarily deployed
to
dockerhub/hashicorpdev
GitHub Actions
Inactive
dhiaayachi
requested changes
Dec 13, 2024
There was a problem hiding this comment.
Hey @abhishek-hashicorp
Thank you for working on this! I left a few comments for your consideration.
abhishek-hashicorp
temporarily deployed
to
dockerhub/hashicorpdev
GitHub Actions
Inactive
abhishek-hashicorp
temporarily deployed
to
dockerhub/hashicorpdev
GitHub Actions
Inactive
dhiaayachi
previously approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Thank you for going through my comments @abhishek-hashicorp, I left 2 minor comments, but nothing blocking 🚀
abhishek-hashicorp
temporarily deployed
to
dockerhub/hashicorpdev
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we update the consul-dataplane health status, we should take into account the service health status as well
Changes proposed in this PR:
consul-dataplaneto take into account the service health as well during health-sync checksHow I've tested this PR:
Created an AWS ECS cluster with 2 services
frontendandbackend. The port for the backend health was misconfigured so that the service fails.Before the fix:
On accessing
curl 0:19000/clustersfrom thefrontendservice, we found that the health forbackendservice was showing as healthy.After the fix:
The
curl 0:19000/clusterswas showingOnce the port was fixed, the
backendservice was again showing as healthy using thecurl 0:19000/clustersendpoint fromfrontendHow I expect reviewers to test this PR:
👀
Checklist: