Mitigate against token replication lag #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthain
approved these changes
Apr 27, 2022
pglass
commented
Apr 28, 2022
subcommand/mesh-init/command.go
Outdated
| newCfg.Address = c.config.ConsulHTTPAddr | ||
| newCfg.TLSConfig.CAFile = c.config.ConsulCACertFile | ||
| newCfg.TokenFile = cfg.TokenFile | ||
| newCfg.Token = cfg.Token |
There was a problem hiding this comment.
I don't love the way I "clone" this config. I could change the function to receive a value/copy, e.g. waitForTokenReplication(cfg api.Config), so that the function receives a copy, but there are some pointer fields on the api.Config type...
Maybe a common function to construct a new config will help.
There was a problem hiding this comment.
What about updating the waitForTokenReplication to just take the token file and token args?.. those are the only fields from the client config that the func uses.
There was a problem hiding this comment.
I updated this. I realized it just needed the TokenFile and not the Token as well.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Copy the consul-k8s approach for dealing with inherent token replication lag.
How I've tested this PR:
How I expect reviewers to test this PR:
👀
Checklist:
CHANGELOG entry addedn/a, part of unreleased auth method changes which are already logged