Fix CRT release pipeline #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 17, 2022 15:48
* This stops using `git describe` as part of the binary version. `git describe` finds the most recent git tag and was previously used as a way to set the version in build flags (`go build -ldflags ...`). With CRT, a git tag is not pushed until the promition to production so we need to set the release version explicitly upfront when the binary is built, rather than rely on a git tag. * Update the build.yml to include the git commit sha in the released binary. Now, `consul-ecs version` includes the commit, `consul-ecs vX.Y.Z (<commit>)`, for released versions.
pglass
requested review from
a team,
samsalisbury,
alvin-huang and
erichaberkorn
and removed request for
a team
erichaberkorn
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
git describefor binary versions, since it relies on git tags existing before the release starts. With CRT, a tag is pushed only after promoting a release to production.How I've tested this PR:
In this commit. See this workflow, which ran the build workflow and a dev and staging promotion.
How I expect reviewers to test this PR:
👀
Checklist: