This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Add datacenter flag to controller deployment #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
requested review from
lkysow,
a team and
kschoche
and removed request for
a team
lkysow
reviewed
Sep 30, 2020
lkysow
approved these changes
Sep 30, 2020
thisisnotashwin
commented
Sep 30, 2020
.circleci/config.yml
Outdated
Comment on lines
143
to
144
| -consul-k8s-image=ashwinvenkatesh/consul-k8s:meta@sha256:531a8865c4c585b53962bef8ff7e7df375741b16ee4f012d53f348deb30ba5f9 \ | ||
| -consul-image=ashwinvenkatesh/consul:meta@sha256:ba215ab440990e19e87f5fa0952f981dcbf2605175b97899dfec259ee1abeca5 |
There was a problem hiding this comment.
These will be reset before the code gets merged
thisisnotashwin
force-pushed
the
add-metadata-to-crds
branch
3 times, most recently
from
51d0fb5 to
9dd843e
Compare
|
@ashwin-venkatesh we need this merged I think for the tests to pass now cuz we've made that flag mandatory. |
thisisnotashwin
force-pushed
the
add-metadata-to-crds
branch
from
9dd843e to
42359f5
Compare
thisisnotashwin
force-pushed
the
add-metadata-to-crds
branch
from
42359f5 to
1f32ec1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR to hashicorp/consul-k8s#343 which passes the datacenter flag to the controller.