helm:Use recommended labels in chart

[rmacduff]

Are there any plans to start using the recommended standard labels in the templates per the best practices doc: https://github.com/helm/helm/blob/master/docs/chart_best_practices/labels.md

app.kubernetes.io/name
helm.sh/chart
app.kubernetes.io/managed-by
app.kubernetes.io/instance
app.kubernetes.io/version
app.kubernetes.io/component
app.kubernetes.io/part-of

This would make it easier to search for kubernetes resources and in logs.

[adilyse]

Hi @rmacduff,

This hadn't come up before, so there is no current plan. It hasn't been a priority, since we're still working to fix some known issues and add vital functionality. I'd be happy to take a look at a PR, though, if you'd like to add them.

One thing to check first though-- we've already had an issue with a label that changed per version interfering with upgrading via Helm (see hashicorp/consul-helm#86). If adding these recommended labels causes the same problem, we'll continue without them.

[david-yu]

We are using component and chart, but not the others mentioned in the original post are not there yet. Please open a PR if you find others that you would like to add to our templates. Closing for now.