Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hostNetwork with pod security policies #1090

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Support hostNetwork with pod security policies #1090

merged 1 commit into from
Mar 21, 2022

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Mar 9, 2022

Changes proposed in this PR:

How I've tested this PR:

  • bats only

How I expect reviewers to test this PR:

  • bats

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@lkysow lkysow requested review from a team, curtbushko and ishustava and removed request for a team March 9, 2022 19:25
ishustava
ishustava reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to do it for the mesh gateway PSP.

charts/consul/templates/server-podsecuritypolicy.yaml Outdated Show resolved Hide resolved
@lkysow
Fix PSPs for clients/mesh gateways for hostPorts
a650467 
When hostNetwork is true, Kube sets all container ports as host ports.
@lkysow lkysow force-pushed the lkysow/hostport branch from 876ee23 to a650467 Compare March 9, 2022 21:32
@lkysow lkysow requested a review from ishustava March 9, 2022 21:33
ishustava
ishustava approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it!! :shipit:

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lkysow lkysow merged commit 639e8cc into main Mar 21, 2022
@lkysow lkysow deleted the lkysow/hostport branch March 21, 2022 19:15
@jmurret jmurret added the type/bug Something isn't working label Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishustava ishustava ishustava approved these changes

@curtbushko curtbushko curtbushko approved these changes

Assignees
No one assigned
Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to launch consul client with podsecuritypolicy.
5 participants
@lkysow @hashicorp-cla @curtbushko @ishustava @jmurret