Expose new options for API Gateway's High Availability feature #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathancoleman
requested review from
mikemorris,
sarahalsmiller,
a team,
ishustava and
Oluwalogoye
and removed request for
a team
This comment was marked as outdated.
This comment was marked as outdated.
nathancoleman
added
area/chart-only
nathancoleman
changed the title
sarahalsmiller
approved these changes
Jun 10, 2022
ishustava
reviewed
Jun 10, 2022
Comment on lines
+2716
to
+2719
| # deployment: | ||
| # defaultInstances: 3 | ||
| # maxInstances: 8 | ||
| # minInstances: 1 |
There was a problem hiding this comment.
How does a user know what are all possible values for deployment?
There was a problem hiding this comment.
Documentation is being added alongside our 0.3.0 release here.
The 3 listed above are all that's supported with our upcoming release.
There was a problem hiding this comment.
Do you want to link to those docs here? Because folks will also see this through https://www.consul.io/docs/k8s/helm
There was a problem hiding this comment.
I can link those, noting that the docs content in the PR linked above won't actually be there for about a week after the consul-k8s release containing this change.
There was a problem hiding this comment.
oh understood. Yeah then we can add it later instead.
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
lkysow
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
GatewayClassConfig0.3.0in the near future.For example:
How I've tested this PR:
helm installwith various combinations of deployment config$ kubectl apply --kustomize "github.com/hashicorp/consul-api-gateway/config/crd?ref=v0.2.1")deploymentat all without updating gateway CRDs0.3.0$ kubectl apply --kustomize "github.com/hashicorp/consul-api-gateway/config/crd?ref=main")deploymentat alldeploymentwith one field at a timedeploymentwith all fields setHow I expect reviewers to test this PR:
See above
Checklist: