-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Destination Field to Service-Defaults for Tproxy Egress #1352
Conversation
Looks like there is some weirdness w/ the new SDK update. Will investigate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent!! Have a comment that should be straightforward to address, but excellent work!!
de21e88
to
c7376e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Dan!! This looks fantastic! Just a few minor comments.
c7376e6
to
3a5660a
Compare
Changes proposed in this PR:
How I've tested this PR:
Short version (detailed test plan available upon request)
Acceptance Tests(?): TBD
How I expect reviewers to test this PR:
Checklist:
TBD Below