Fix #146 add annotation for add http check

[Veres72]

I try to resolve #146
Annotation, that add service HTTP check with POD_IP and ServicePort.
It allows adding HTTP checks because by default services check only by TCP check.

[hashicorp-cla]

All committers have signed the CLA.

[lkysow]

Might solve #155

[omerlh]

Any update regarding this PR? Will it be merged?

[pbusko]

Any chance that this PR will be merged?

[lkysow]

Hi @pbusko and others, we need to do a broad review of our approach to health checks so I don't think this will be merged until we get to that. The things we need to think about are:

• should we support consul-specific health checks or do we want to hook into the kube readiness or liveliness checks so users don't need to configure both
• if we hook into readiness/liveness probes which ones do we use and how does this effect connect traffic
• how do we integrate with the external paths support for exposing services through the envoy proxy

[lkysow]

Hi all, with the release of consul-helm 0.26.0 we support syncing kube readiness status to Consul. So instead of setting checks via annotations in the PR can you try creating kube readiness probes? That way Consul and Kube will agree on the readiness status.

[lkysow]

Closing because setting kube readiness probes is the recommended way.