Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] disable 1.11 nightly testing #1616

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

kschoche
Copy link
Contributor

Changes proposed in this PR:

  • release/0.49.0 was released with CRDs which are backward incompatible with Consul 1.11 which will be EOL soon, disable the 1-11 nightlies.
    This should make the nightlies go 🍏

How I've tested this PR:
Validated that 0.49.x still works with consul 1.12+1.13 and that consul-1.11 does not have this config entry.

CI pipelines fail due to invalid CRDs:

2022-10-12T15:46:00.512Z        ERROR   controller.servicedefaults      Reconciler error        {"reconciler group": "consul.hashicorp.com", "reconciler kind": "ServiceDefaults", "name": "defaults", "namespace": "ns1", "error": "writing config entry to consul: Unexpected response code: 400 (Bad request: Request decoding failed: 1 error occurred:\n\t* invalid config key \"UpstreamConfig.Overrides[0].PassiveHealthCheck.EnforcingConsecutive5xx\")"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
        /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.2/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
        /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.2/pkg/internal/controller/controller.go:227
^C
demo $ grep -R EnforcingConsecutive5xx ./
.//CHANGELOG.md:  * New parameter `EnforcingConsecutive5xx` which supports a configurable percent chance of automatic ejection of a host when a consecutive number of 5xx response codes are received [[GH-1484](https://github.com/hashicorp/consul-k8s/pull/1484)]

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@kschoche kschoche requested a review from a team October 12, 2022 17:46
@kschoche kschoche self-assigned this Oct 12, 2022
@kschoche kschoche requested review from analogue and ishustava and removed request for a team October 12, 2022 17:46
Copy link
Member

@jmurret jmurret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🙏

@kschoche kschoche requested a review from curtbushko October 13, 2022 16:50
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@kschoche kschoche merged commit 2d0207e into main Oct 13, 2022
@kschoche kschoche deleted the update_circleci_stop_testing_111_nightly branch October 13, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants