Gateway anti-affinity and replicas #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
changed the base branch from
main
to
ashwin/merge-controllers
thisisnotashwin
force-pushed
the
ashwin/anti-affinity
branch
from
f3aa935 to
7a5fc07
Compare
thisisnotashwin
force-pushed
the
ashwin/anti-affinity
branch
from
7a5fc07 to
9be8c3c
Compare
curtbushko
approved these changes
Nov 11, 2022
thisisnotashwin
commented
Nov 11, 2022
| @@ -77,7 +77,7 @@ global: | |||
| # - name: pull-secret-name-2 | |||
| # ``` | |||
| # @type: array<map> | |||
| imagePullSecrets: [] | |||
| imagePullSecrets: [ ] | |||
There was a problem hiding this comment.
Majority of the changes in this file related to indentation or spacing between the brackets were done automatically by the IDE.
ishustava
reviewed
Nov 11, 2022
thisisnotashwin
force-pushed
the
ashwin/merge-controllers
branch
from
437eee1 to
2c63ccc
Compare
thisisnotashwin
force-pushed
the
ashwin/anti-affinity
branch
from
9be8c3c to
3fff75f
Compare
thisisnotashwin
force-pushed
the
ashwin/anti-affinity
branch
from
3fff75f to
0c25438
Compare
ishustava
approved these changes
Nov 12, 2022
thisisnotashwin
force-pushed
the
ashwin/anti-affinity
branch
from
0c25438 to
2e1ffef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: