update kind to kubernetes-1.25 and mark Kubernetes-1.25 supported #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschoche
changed the title
kschoche
requested review from
a team,
jmurret and
wilkermichael
and removed request for
a team
| @@ -573,7 +573,7 @@ jobs: | |||
| - checkout | |||
| - install-prereqs | |||
| - create-kind-clusters: | |||
| version: "v1.24.4" | |||
| version: "v1.25.3" | |||
There was a problem hiding this comment.
latest release is 1.25.4, just want to verify if that should be reflected here?
There was a problem hiding this comment.
Oh weird, I looked a couple hours ago and 1.25.3 was the latest! let me look..
There was a problem hiding this comment.
From the kind release page:
The default node image is a Kubernetes v1.25.3 .. so I guess it makes sense to stay with the defaults for the latest version of Kind?
| @@ -7,6 +7,16 @@ load _helpers | |||
| assert_empty helm template \ | |||
| -s templates/webhook-cert-manager-podsecuritypolicy.yaml \ | |||
| --set 'connectInject.enabled=false' \ | |||
| --set 'global.enablePodSecurityPolicies=true' \ | |||
There was a problem hiding this comment.
Shouldn't this be disabled as per the test case?
There was a problem hiding this comment.
It should be connect:false and psp: true, we're testing if turning off connect makes the PSP not template out.
kschoche
commented
Nov 16, 2022
charts/consul/test/unit/webhook-cert-manager-podsecuritypolicy.bats
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Wilkerson <62034708+wilkermichael@users.noreply.github.com>
ndhanushkodi
approved these changes
Nov 17, 2022
thisisnotashwin
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
acceptance tests still pass: https://app.circleci.com/pipelines/github/hashicorp/consul-k8s/9531/workflows/75acb13f-c9ea-4838-8f38-a994da93f860/jobs/66796
How I expect reviewers to test this PR:
👀
Checklist: