Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add go-discover binary to control-plane image #1749

Merged
merged 3 commits into from
Nov 21, 2022
Merged

add go-discover binary to control-plane image #1749

merged 3 commits into from
Nov 21, 2022

Conversation

curtbushko
Copy link
Contributor

@curtbushko curtbushko commented Nov 21, 2022 •
edited
Loading

Changes proposed in this PR:

  • Adds the go-discover binary to /bin

How I've tested this PR:

  • unit & acceptance tests
  • manually exec'd into the image I created to make sure that the discover binary was there and would run

How I expect reviewers to test this PR:

👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@curtbushko curtbushko marked this pull request as ready for review November 21, 2022 15:56
thisisnotashwin
thisisnotashwin approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we build an image from this ask the person who raised the issue on github to try it?? thanks for taking care of this Curt!

t-eckert
t-eckert approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@t-eckert t-eckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You dropped this 👑

@curtbushko curtbushko mentioned this pull request Nov 21, 2022
Closed
@curtbushko
Copy link
Contributor Author

@thisisnotashwin Yes, I have tagged mr-miles in the github issue and let them know that I would get an image to them if they want to try it out.

kschoche
kschoche reviewed Nov 21, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@curtbushko @kschoche
Update CHANGELOG.md
c6070da 
Co-authored-by: Kyle Schochenmaier <kschoche@gmail.com>
@ndhanushkodi
Copy link
Contributor

We want to backport this to 1.0.x right? Just a reminder to add the label!! Thank you for making the fix!

@curtbushko curtbushko merged commit 94506bb into main Nov 21, 2022
@curtbushko curtbushko deleted the curtbushko/missing-go-discover branch November 21, 2022 17:49
Merged
2 tasks
@curtbushko curtbushko self-assigned this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-eckert t-eckert t-eckert approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@kschoche kschoche kschoche approved these changes

@wilkermichael wilkermichael Awaiting requested review from wilkermichael

Assignees

@curtbushko curtbushko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@curtbushko @ndhanushkodi @kschoche @thisisnotashwin @t-eckert