-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TLS Cert when using enableAutoEncrypt
#1753
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-eckert
requested review from
andrewstucki,
a team,
kschoche and
ishustava
and removed request for
a team
November 28, 2022 22:55
ishustava
approved these changes
Nov 28, 2022
t-eckert
force-pushed
the
te/fix-tls-autogen
branch
2 times, most recently
from
November 29, 2022 02:33
c6bf305
to
d486e02
Compare
nathancoleman
added
theme/api-gateway
Related to Consul API Gateway
area/chart-only
Related to changes that simply require yaml Helm chart changes, e.g. exposing a new field
labels
Nov 29, 2022
…rs on main container
t-eckert
force-pushed
the
te/fix-tls-autogen
branch
from
November 30, 2022 21:52
a889467
to
005e147
Compare
curtbushko
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/chart-only
Related to changes that simply require yaml Helm chart changes, e.g. exposing a new field
theme/api-gateway
Related to Consul API Gateway
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
consul-ca-cert
consul-ca-cert
to talk to servers if running without clients. It will useconsul-auto-encrypt-ca-cert
to talk to clients only if running with clients.How I've tested this PR:
tls.enableAutoEncrypt=false
client.enabled=false
apiGateway.image=...0.5.1
tls.enableAutoEncrypt=true
client.enabled=false
apiGateway.image=...0.5.1
tls.enableAutoEncrypt=false
client.enabled=true
apiGateway.image=...0.5.1
tls.enableAutoEncrypt=true
client.enabled=true
apiGateway.image=...0.5.1
tls.enableAutoEncrypt=true
client.enabled=true
apiGateway.image=...0.4.0
How I expect reviewers to test this PR:
Checklist: