Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of When configured, use the health check of the proxy into release/1.0.x #1842

Conversation

thisisnotashwin
Copy link
Contributor

Backport

This PR is auto-generated from #1841 to be assessed for backporting due to the inclusion of the label backport/1.0.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • When a service is configured with the correct annotation, a readiness endpoint with be configured in Consul dataplane, and the readiness probe of the sidecar will be configured to use that endpoint to determine the health of the system. Additionally, when t-proxy is enabled, that port shall be in the ExcludeList for inbound connections.

How I've tested this PR:

  • By deploying zookeeper with and without this annotation and noticing the absence of the lack of the following exception.
EndOfStreamException: Unable to read additional data from client sessionid 0x0, likely client has closed socket
	at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:239)
	at org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:203)
	at java.lang.Thread.run(Thread.java:748)

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)


Overview of commits

@thisisnotashwin thisisnotashwin force-pushed the backport/ashwin/use-proxy-health-check/instantly-novel-pup branch from d35c91a to a3d55d0 Compare January 19, 2023 16:22
@thisisnotashwin thisisnotashwin merged commit 805ac6e into release/1.0.x Jan 19, 2023
@thisisnotashwin thisisnotashwin deleted the backport/ashwin/use-proxy-health-check/instantly-novel-pup branch January 19, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant