Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Refine server TLS Vault PKI role config in acceptance tests into release/1.0.x #1879

Conversation

thisisnotashwin
Copy link
Contributor

Backport

This PR is auto-generated from #1877 to be assessed for backporting due to the inclusion of the label backport/1.0.x.

The below text is copied from the body of the original PR.


The generate_lease=true configuration is unnecessary and generates a note about performance implications in Vault logs. Remove this configuration from the acceptance tests so that the default value of generate_lease=false is used instead.

A follow on PR will update the public Consul docs to reflect this change in recommendation.

How I've tested this PR:

  • I'm relying on the existing k8s acceptance tests to ensure the integration still works

Checklist:

  • Tests added: No - relying on existing tests
  • CHANGELOG entry added: Seems unnecessary since this only affects the acceptance tests, not consul k8s itself

Overview of commits

@thisisnotashwin thisisnotashwin force-pushed the backport/refine-server-tls-vault-pki-role-config/arguably-intent-bengal branch from 986e42b to 7594b53 Compare February 6, 2023 02:04
@thisisnotashwin thisisnotashwin merged commit 02fb868 into release/1.0.x Feb 6, 2023
@thisisnotashwin thisisnotashwin deleted the backport/refine-server-tls-vault-pki-role-config/arguably-intent-bengal branch February 6, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants