Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Adjust API gateway controller deployment appropriately when Vault configured as secrets backend into release/1.0.x #2094

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #2083 to be assessed for backporting due to the inclusion of the label backport/1.0.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:
Consider whether Vault is being used as a secrets backend when determining whether to mount a TLS cert into the API gateway controller deployment.

Largely, this change is based off of how other deployments already handle Vault as a secrets backend. For example:

{{- if and .Values.global.tls.enabled (not (or (and .Values.externalServers.enabled .Values.externalServers.useSystemRoots) .Values.global.secretsBackend.vault.enabled))}}
- name: consul-ca-cert
mountPath: /consul/tls/ca
readOnly: true
{{- end }}

The only unique aspect here is that the api-gateway-controller communicates directly with agents when client.enabled=true, so we require some additional gating to make sure that we're using the correct cert in this case.

How I've tested this PR:
Install Consul w/ API gateway enabled in configurations both with and without Vault used as a secrets backend. In each case, verify that the API gateway controller is able to start up successfully and that deployed API gateways function correctly.

Install Consul w/ external server configuration (HCP, for example). Test with and without clients enabled.

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/apigw-vault-secrets-backend-1.1.x/virtually-rapid-moose branch from 9b56874 to 90a7f08 Compare April 27, 2023 19:47
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) April 27, 2023 19:47
@hc-github-team-consul-core hc-github-team-consul-core merged commit 38ba8fb into release/1.0.x Apr 27, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/apigw-vault-secrets-backend-1.1.x/virtually-rapid-moose branch April 27, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants