Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default Ent image tag in acceptance tests #2683

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Fix default Ent image tag in acceptance tests #2683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
909590b
Fix default Ent image tag in acceptance tests
zalimeni Jul 28, 2023
d38b7ac
Add make target for loading images in kind
zalimeni Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,13 @@ kind: kind-delete
kind create cluster --name dc3 --image $(KIND_NODE_IMAGE)
kind create cluster --name dc4 --image $(KIND_NODE_IMAGE)

# Helper target for loading local dev images (run with `DEV_IMAGE=...` to load non-k8s images)
kind-load:
kind load docker-image --name dc1 $(DEV_IMAGE)
kind load docker-image --name dc2 $(DEV_IMAGE)
kind load docker-image --name dc3 $(DEV_IMAGE)
kind load docker-image --name dc4 $(DEV_IMAGE)

# ===========> Shared Targets

help: ## Show targets and their descriptions.
Expand Down
21 changes: 8 additions & 13 deletions acceptance/framework/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,21 +217,16 @@ func (t *TestConfig) entImage() (string, error) {
}

// Otherwise, assume that we have an image tag with a version in it.
consulImageSplits := strings.Split(v.Global.Image, ":")
if len(consulImageSplits) != 2 {
return "", fmt.Errorf("could not determine consul version from global.image: %s", v.Global.Image)
}
consulImageVersion := consulImageSplits[1]

var preRelease string
// Handle versions like 1.9.0-rc1.
if strings.Contains(consulImageVersion, "-") {
split := strings.Split(consulImageVersion, "-")
consulImageVersion = split[0]
preRelease = fmt.Sprintf("-%s", split[1])
// Use the same Docker repository and tagging scheme, but replace 'consul' with 'consul-enterprise'.
imageTag := strings.Replace(v.Global.Image, "/consul:", "/consul-enterprise:", 1)

// We currently add an '-ent' suffix to release versions of enterprise images (nightly previews
// do not include this suffix).
if strings.HasPrefix(imageTag, "hashicorp/consul-enterprise:") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense and your unit test covers it!

imageTag = fmt.Sprintf("%s-ent", imageTag)
}

return fmt.Sprintf("hashicorp/consul-enterprise:%s%s-ent", consulImageVersion, preRelease), nil
return imageTag, nil
}

func (c *TestConfig) SkipWhenOpenshiftAndCNI(t *testing.T) {
Expand Down
29 changes: 19 additions & 10 deletions acceptance/framework/config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,25 +137,34 @@ func TestConfig_HelmValuesFromConfig_EntImage(t *testing.T) {
expErr string
}{
{
consulImage: "hashicorp/consul:1.9.0",
expImage: "hashicorp/consul-enterprise:1.9.0-ent",
consulImage: "hashicorp/consul:1.15.3",
expImage: "hashicorp/consul-enterprise:1.15.3-ent",
},
{
consulImage: "hashicorp/consul:1.8.5-rc1",
expImage: "hashicorp/consul-enterprise:1.8.5-rc1-ent",
consulImage: "hashicorp/consul:1.16.0-rc1",
expImage: "hashicorp/consul-enterprise:1.16.0-rc1-ent",
},
{
consulImage: "hashicorp/consul:1.7.0-beta3",
expImage: "hashicorp/consul-enterprise:1.7.0-beta3-ent",
},
{
consulImage: "invalid",
expErr: "could not determine consul version from global.image: invalid",
consulImage: "hashicorp/consul:1.14.0-beta1",
expImage: "hashicorp/consul-enterprise:1.14.0-beta1-ent",
},
{
consulImage: "hashicorp/consul@sha256:oioi2452345kjhlkh",
expImage: "hashicorp/consul@sha256:oioi2452345kjhlkh",
},
// Nightly tags differ from release tags ('-ent' suffix is omitted)
{
consulImage: "docker.mirror.hashicorp.services/hashicorppreview/consul:1.17-dev",
expImage: "docker.mirror.hashicorp.services/hashicorppreview/consul-enterprise:1.17-dev",
},
{
consulImage: "docker.mirror.hashicorp.services/hashicorppreview/consul:1.17-dev-ubi",
expImage: "docker.mirror.hashicorp.services/hashicorppreview/consul-enterprise:1.17-dev-ubi",
},
{
consulImage: "docker.mirror.hashicorp.services/hashicorppreview/consul@sha256:oioi2452345kjhlkh",
expImage: "docker.mirror.hashicorp.services/hashicorppreview/consul@sha256:oioi2452345kjhlkh",
},
}
for _, tt := range tests {
t.Run(tt.consulImage, func(t *testing.T) {
Expand Down