Backport of NET-4806: Fix ACL tokens for pods don't have pod name set into release/1.0.x #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/derekm/NET-4806/acl-token-missing-pod/yearly-chief-squirrel
branch
from
f7d8fb2 to
a5495ee
Compare
hc-github-team-consul-core
force-pushed
the
backport/derekm/NET-4806/acl-token-missing-pod/yearly-chief-squirrel
branch
from
c8611dd to
2422e38
Compare
hashi-derek
approved these changes
Aug 22, 2023
hc-github-team-consul-core
deleted the
backport/derekm/NET-4806/acl-token-missing-pod/yearly-chief-squirrel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2808 to be assessed for backporting due to the inclusion of the label backport/1.0.x.
The below text is copied from the body of the original PR.
Prior to this PR, tokens descriptions would have a missing pod name and would have the form:
{pod: "default/"}This poses issues for the endpoints controller, which will try to parse the metadata and use it to clean up the token. Without the pod name, consul-k8s will continually leak tokens.
Changes proposed in this PR:
How I've tested this PR:
Ran a cluster locally and manually inspected the token description field includes the pod name. Added a new step to an acceptance test.
How I expect reviewers to test this PR:
👀
Checklist:
Overview of commits