Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force a check on controller-gen version #2902

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Force a check on controller-gen version #2902

merged 1 commit into from
Sep 7, 2023

Conversation

t-eckert
Copy link
Contributor

@t-eckert t-eckert commented Sep 5, 2023 •
edited
Loading

Changes proposed in this PR:

  • Adds a check that the controller-gen binary is the correct version before generating CRDs

How I've tested this PR:

  • I ran this with no controller-gen binary installed and the Makefile installed the correct version for me.
Screenshot 2023-09-05 at 1 48 42 PM
  • I ran this with the correct controller-gen binary installed and the Makefile used it.
  • I ran this with an incorrect version of the controller-gen binary installed and the Makefile stopped me and told me how to fix the problem.
Screenshot 2023-09-05 at 1 43 51 PM

How I expect reviewers to test this PR:

Checklist:

@t-eckert t-eckert requested review from lkysow and DanStough September 5, 2023 17:52
@t-eckert t-eckert added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Sep 5, 2023
lkysow
lkysow approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

DanStough
DanStough approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@t-eckert t-eckert merged commit 516d762 into main Sep 7, 2023
@t-eckert t-eckert deleted the force-correct-controller-gen branch September 7, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanStough DanStough DanStough approved these changes

@lkysow lkysow lkysow approved these changes

Assignees
No one assigned
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t-eckert @lkysow @DanStough