Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for acceptance tests #2937

Merged
merged 7 commits into from
Sep 12, 2023
Merged

Fix for acceptance tests #2937

merged 7 commits into from
Sep 12, 2023

Conversation

absolutelightning
Copy link
Contributor

@absolutelightning absolutelightning commented Sep 11, 2023 •
edited
Loading

Changes proposed in this PR:

How I've tested this PR:
Ran the test on local.

How I expect reviewers to test this PR:

Checklist:

@absolutelightning absolutelightning marked this pull request as ready for review September 11, 2023 15:58
@absolutelightning absolutelightning added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Sep 11, 2023
@absolutelightning
Copy link
Contributor Author

I am updating the bats test now. Please keep go ahead with review.

zalimeni
zalimeni previously approved these changes Sep 11, 2023
View reviewed changes
@zalimeni
Copy link
Member

zalimeni commented Sep 11, 2023 •
edited
Loading

@absolutelightning it looks like the original change was backported to 1.2.x, 1.1.x and 1.0.x. We typically don't backport features, so it might make sense to revert those changes. If not, I'd expect we'll need this fix backported as well.

@zalimeni zalimeni dismissed their stale review September 11, 2023 21:53

New test is failing

@absolutelightning absolutelightning added backport/1.0.x backport/1.1.x Backport to release/1.1.x branch backport/1.2.x This release branch is no longer active. and removed pr/no-backport signals that a PR will not contain a backport label labels Sep 12, 2023
@absolutelightning absolutelightning self-assigned this Sep 12, 2023
Ganeshrockz
Ganeshrockz approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@Ganeshrockz Ganeshrockz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Do wait for the CI to become green before merging this.

@absolutelightning
Copy link
Contributor Author

absolutelightning commented Sep 12, 2023 •
edited
Loading

Acceptance CNI - Partition test is only failing but it is not related to my change. Hence merging the PR since CI is 99% green.

@absolutelightning absolutelightning merged commit 43fb01e into main Sep 12, 2023
@absolutelightning absolutelightning deleted the fix-acceptance-test branch September 12, 2023 07:53
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Sep 12, 2023
Merged
1 task
This was referenced Sep 12, 2023
Merged
Closed
absolutelightning added a commit that referenced this pull request Sep 12, 2023
@absolutelightning
Fix for acceptance tests (#2937)
0aa49d2 
* Fix for acceptance tests

* fix accpetance test

* fix spaces

* fix get

* added bats test

* fix test name

* fix bats
absolutelightning added a commit that referenced this pull request Sep 12, 2023
@absolutelightning
Fix for acceptance tests (#2937)
7ff7258 
* Fix for acceptance tests

* fix accpetance test

* fix spaces

* fix get

* added bats test

* fix test name

* fix bats
absolutelightning added a commit that referenced this pull request Sep 12, 2023
@absolutelightning
Fix for acceptance tests (#2937)
4b38149 
* Fix for acceptance tests

* fix accpetance test

* fix spaces

* fix get

* added bats test

* fix test name

* fix bats
@absolutelightning absolutelightning mentioned this pull request Sep 12, 2023
Merged
1 task
absolutelightning added a commit that referenced this pull request Sep 12, 2023
@absolutelightning
Fix for acceptance tests (#2937)
4b9fdaf 
* Fix for acceptance tests

* fix accpetance test

* fix spaces

* fix get

* added bats test

* fix test name

* fix bats
absolutelightning added a commit that referenced this pull request Sep 12, 2023
@hc-github-team-consul-core @absolutelightning
Backport of Fix for acceptance tests into release/1.0.x (#2942)
6085fc2 
* backport of commit fcb1b3e

* Fix for acceptance tests (#2937)

* Fix for acceptance tests

* fix accpetance test

* fix spaces

* fix get

* added bats test

* fix test name

* fix bats

* fix changes

* revert file

---------

Co-authored-by: absolutelightning <ashesh.vidyut@hashicorp.com>
Co-authored-by: Ashesh Vidyut <134911583+absolutelightning@users.noreply.github.com>
absolutelightning added a commit that referenced this pull request Sep 12, 2023
@absolutelightning
Fix for acceptance tests (#2937) (#2945)
75dabae 
* Fix for acceptance tests

* fix accpetance test

* fix spaces

* fix get

* added bats test

* fix test name

* fix bats
@absolutelightning absolutelightning added the consul-india PRs/Issues assigned to Consul India team label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ganeshrockz Ganeshrockz Ganeshrockz approved these changes

@kschoche kschoche Awaiting requested review from kschoche

@zalimeni zalimeni Awaiting requested review from zalimeni

Assignees

@absolutelightning absolutelightning

Labels
backport/1.1.x Backport to release/1.1.x branch backport/1.2.x This release branch is no longer active. consul-india PRs/Issues assigned to Consul India team pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@absolutelightning @zalimeni @Ganeshrockz