-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge POC into consul-k8s #309
Conversation
76b69ca
to
ee44718
Compare
Signed-off-by: Ashwin Venkatesh <ashwin@hashicorp.com>
- Update Makefile with some code-gen tasks
3dddaf4
to
ef24988
Compare
- Controller now runs from consul-k8s image
ef24988
to
5a32358
Compare
fc9a93d
to
b0d3e58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 wow this was a lot of code! We can pair on some of these suggestions.
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
23b64d4
to
5c2987b
Compare
a9e6e56
to
a6f4d9a
Compare
c8ddcd1
to
40ec5ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! A lot of stuff going on here, and only a few non-blocking comments which can be discussed when we try to merge to master!
Great work!
Introduce changes made in the POC to crd base branch.
How I've tested this PR:
Run the controller in my GCR cluster and create ServiceDefaults.
Steps:
kubectl apply --validate=false -f https://github.com/jetstack/cert-manager/releases/download/v0.15.2/cert-manager-legacy.yaml
helm install consul hashicorp/consul --set server.bootstrapExpect=1 --set server.replicas=1
make ctrl-deploy IMG=ashwinvenkatesh/consul-k8s:latest
kubectl apply -f defaults.yaml
deafults.yaml
Check controller logs to see reconcile successful.
How I expect reviewers to test this PR:
Repeat above steps. Try and break stuff.
Checklist: