Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge POC into consul-k8s #309

Merged
merged 20 commits into from
Aug 27, 2020
Merged

Merge POC into consul-k8s #309

merged 20 commits into from
Aug 27, 2020

Conversation

thisisnotashwin
Copy link
Contributor

@thisisnotashwin thisisnotashwin commented Aug 13, 2020

Introduce changes made in the POC to crd base branch.

How I've tested this PR:
Run the controller in my GCR cluster and create ServiceDefaults.
Steps:

  1. kubectl apply --validate=false -f https://github.com/jetstack/cert-manager/releases/download/v0.15.2/cert-manager-legacy.yaml
  2. helm install consul hashicorp/consul --set server.bootstrapExpect=1 --set server.replicas=1
  3. make ctrl-deploy IMG=ashwinvenkatesh/consul-k8s:latest
  4. kubectl apply -f defaults.yaml

deafults.yaml

apiVersion: consul.hashicorp.com/v1alpha1
kind: ServiceDefaults
metadata:
  name: servicedefaults-sample
spec:
  protocol: "http"

Check controller logs to see reconcile successful.

How I expect reviewers to test this PR:
Repeat above steps. Try and break stuff.

Checklist:

  • Tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@thisisnotashwin thisisnotashwin requested review from lkysow, a team and kschoche and removed request for a team August 13, 2020 21:32
@thisisnotashwin thisisnotashwin marked this pull request as ready for review August 24, 2020 16:44
Makefile Outdated Show resolved Hide resolved
- Controller now runs from consul-k8s image
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 wow this was a lot of code! We can pair on some of these suggestions.

PROJECT Show resolved Hide resolved
PROJECT Show resolved Hide resolved
api/v1alpha1/servicedefaults_types.go Outdated Show resolved Hide resolved
api/v1alpha1/types.go Show resolved Hide resolved
api/v1alpha1/types.go Outdated Show resolved Hide resolved
subcommand/controller/command.go Outdated Show resolved Hide resolved
subcommand/controller/command.go Outdated Show resolved Hide resolved
subcommand/controller/command.go Outdated Show resolved Hide resolved
api/v1alpha1/servicedefaults_types_test.go Show resolved Hide resolved
controllers/suite_test.go Outdated Show resolved Hide resolved
Ashwin Venkatesh and others added 4 commits August 25, 2020 16:29
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
api/v1alpha1/servicedefaults_types.go Outdated Show resolved Hide resolved
api/v1alpha1/servicedefaults_types.go Outdated Show resolved Hide resolved
api/v1alpha1/servicedefaults_types.go Outdated Show resolved Hide resolved
api/v1alpha1/servicedefaults_types.go Outdated Show resolved Hide resolved
api/v1alpha1/servicedefaults_types_test.go Outdated Show resolved Hide resolved
api/v1alpha1/types.go Outdated Show resolved Hide resolved
api/v1alpha1/types.go Outdated Show resolved Hide resolved
build-support/controller/README.md Outdated Show resolved Hide resolved
subcommand/controller/command.go Outdated Show resolved Hide resolved
api/v1alpha1/servicedefaults_types_test.go Show resolved Hide resolved
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! A lot of stuff going on here, and only a few non-blocking comments which can be discussed when we try to merge to master!

Great work!

api/v1alpha1/types.go Outdated Show resolved Hide resolved
api/v1alpha1/types.go Outdated Show resolved Hide resolved
config/rbac/role.yaml Show resolved Hide resolved
config/webhook/manifests.yaml Outdated Show resolved Hide resolved
config/webhook/service.yaml Show resolved Hide resolved
config/webhook/manifests.yaml Show resolved Hide resolved
controllers/servicedefaults_controller.go Show resolved Hide resolved
@thisisnotashwin thisisnotashwin merged commit 55bd0f5 into crd-controller-base Aug 27, 2020
@thisisnotashwin thisisnotashwin deleted the crdPOC branch August 27, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants