Add defaults and validation for ServiceDefaults #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
force-pushed
the
servce-defaults-validation
branch
from
0f1acdf to
9ea49fa
Compare
thisisnotashwin
requested review from
lkysow,
a team and
ishustava
and removed request for
a team
thisisnotashwin
force-pushed
the
servce-defaults-validation
branch
from
f2f7b1d to
03ada6a
Compare
ishustava
reviewed
Sep 8, 2020
There was a problem hiding this comment.
The validating logic looks awesome!
I wasn't super sure if we need defaulting though. It seems like a duplication of logic that already exists in Consul, and so I'm not sure what is the value of having it in the controller as well. It also couples us to consul versions more tightly - if consul changes defaults, you'd need to update to the version of the controller/consul-k8s that has that default.
ishustava
added
area/connect
lkysow
reviewed
Sep 11, 2020
lkysow
reviewed
Sep 11, 2020
thisisnotashwin
force-pushed
the
servce-defaults-validation
branch
from
d0989eb to
d0a466c
Compare
lkysow
approved these changes
Sep 15, 2020
thisisnotashwin
force-pushed
the
servce-defaults-validation
branch
from
1e3740e to
bc3686a
Compare
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Add defaulting and validation for ServiceDefaults
Checklist:
How I tested the PR:
• Used the image
ashwinvenkatesh/consul-k8s:validationto deploy consul via helm with the controller enabled.• Tried creating service default resource with
• Invalid mesh gateway mode
• Invalid expose path protocol (not in "http" and "http2") and path value (not prefixed by "/")
This led to webhook errors which indicated the invalid fields
• Combinations of various invalid values for the above fields
This led to webhook errors that listed every single invalid field
How I expect people to test the PR:
• You can retry the above scenarios with multiple invalid values to verify every invalid value is mentioned in the returned error from the webhook.