Backport of Helm: support sync-lb-services-endpoints for sync catalog into release/1.3.x #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/zalimeni/test/jukie/feat/helm-support-sync-lb-services-endpoints/jointly-present-akita
branch
from
d14ec9f to
5804fa3
Compare
zalimeni
approved these changes
Apr 16, 2024
hc-github-team-consul-core
merged commit ebddf11
into
release/1.3.x
45 of 49 checks passed
hc-github-team-consul-core
deleted the
backport/zalimeni/test/jukie/feat/helm-support-sync-lb-services-endpoints/jointly-present-akita
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #3905 to be assessed for backporting due to the inclusion of the label backport/1.3.x.
The below text is copied from the body of the original PR.
This PR adds a test and fixes a minor issue in the original #3875, plus runs privileged tests required to merge.
I intend to backport this change to all active versions as it exposes a feature that's existed in
consul-k8ssince well before those releases.Changes proposed in this PR
sync-lb-services-endpointsstartup flagHow I've tested this PR
helm template
How I expect reviewers to test this PR
Validate that if the helm value is set to true that it's correctly rendered in the deployment manifest
Checklist
fixes #3899
Overview of commits