Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: allow configuration of container liveness and readiness probes #4388

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jukie
Copy link
Contributor

@jukie jukie commented Oct 15, 2024

Changes proposed in this PR

  • Adds livenessProbe field to helm values - empty by default
  • Adds readinessProbe field to helm values - defaults to existing readinessProbe

How I've tested this PR

  • Currently using a forked chart with this change
  • helm template . -f values.yaml to compare diffs and none of the defaults are changed

How I expect reviewers to test this PR

Checklist

Fixes #4387

@jukie jukie requested a review from a team as a code owner October 15, 2024 21:45
@poblahblahblah
Copy link

Would love to see this merged in

@michelmzs
Copy link

We're looking forward to this feature. We forked the chart specifically to customize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm: allow customization of container livenessProbe and readinessProbe
3 participants