Test fix for [NET-11043] crd: support request normalization and header match options to prevent L7 intentions bypass in release/1.6.x #4402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/zalimeni/net-11043-l7-intentions-updates-support/wildly-suited-parrot
branch
from
7083a5f
to
864aa1f
Compare
zalimeni
force-pushed
the
backport/zalimeni/net-11043-l7-intentions-updates-support/wildly-suited-parrot
branch
from
864aa1f
to
68d4087
Compare
zalimeni
changed the title
zalimeni
approved these changes
Oct 18, 2024
zalimeni
reviewed
Oct 18, 2024
| BindName: "", //api.ACLTemplatedPolicyWorkloadIdentityName, TODO: remove w/ v2 code | ||
| BindName: "builtin/workload-identity", // TODO: remove w/ v2 code |
There was a problem hiding this comment.
Using a literal because in the corresponding api submodule version, this constant has been removed.
zalimeni
deleted the
backport/zalimeni/net-11043-l7-intentions-updates-support/wildly-suited-parrot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #4385 to be assessed for backporting due to the inclusion of the label backport/1.6.x.
The below text is copied from the body of the original PR.
Changes proposed in this PR
Supports changes in hashicorp/consul#21816 with CRD updates:
How I've tested this PR
kindand validated both changes are reflected in xDS / config when created as CRDsHow I expect reviewers to test this PR
👀 + spot check me on the CRD update process in case I missed a step. It's been a while since I've done one of these.
Checklist
Overview of commits