Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow nomad naming convention #4408

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Follow nomad naming convention #4408

wants to merge 1 commit into from
+30 −32

Conversation

tholcman
Copy link

@tholcman tholcman commented Oct 25, 2024 •
edited
Loading

Changes proposed in this PR

  • clusterIP service endpoints will have ID based on pod identification
  • nodePort service endpoints will have ID based on node name
  • removing iteration over endpointAddr := range endpoint.Addresses as it is not used

The change will allow to associate multiple services pointing to same workload instance (pod/node). It follows nomad services naming standard.

How I've tested this PR

  • Tested only on ClusterIP in multiple clusters

How I expect reviewers to test this PR

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tholcman