Add custom labels for connectInject, acl init, and mesh gateway pods

[jeanmorais]

Changes proposed in this PR:

• Add custom labels for connectInject, acl init, and mesh gateway pods via Helm.

How I've tested this PR:

• Unit tests

Fixes #759

How I expect reviewers to test this PR:

• bats connect-inject-deployment.bats
• bats mesh-gateway-deployment.bats
• bats server-acl-init-job.bats

Checklist:

• Tests added
• CHANGELOG entry added

  HashiCorp engineers only, community PRs should not add a changelog entry.
  Entries should use present tense (e.g. Add support for...)

[t-eckert]

This looks great! You did a fantastic job of following the patterns set by the previous extra labels work. Thank you!

I misunderstood how this connects into acl init.

[t-eckert]

Hi @jeanmorais, I apologize for reviewing and then rescinding the review. Your PR definitely meets the mark for the issue it addresses, but there is now some question around the user experience as it relates to that issue and adding stanzas. We will discuss the UX as a team and get back to you soon. Once again, I apologize for the confusion.

[jeanmorais]

Hi @jeanmorais, I apologize for reviewing and then rescinding the review. Your PR definitely meets the mark for the issue it addresses, but there is now some question around the user experience as it relates to that issue and adding stanzas. We will discuss the UX as a team and get back to you soon. Once again, I apologize for the confusion.

Hey @t-eckert, no problem! Let me know if any adaptations are needed in this PR, as soon as your team decides how to proceed.

[hashicorp-cla]

All committers have signed the CLA.

[david-yu]

Hi @jeanmorais Sorry we did not get back to you since the last review. We've had some internal discussions on this recently, and it was decided that perhaps the better approach would be to re-do labeling globally as opposed to on a per stanza basis. I will close this PR and this issue for now but if you would like to move forward with a PR for global labels please open a new PR. We did accept this for hacktoberfest so hopefully you received credit for the work.