-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Cross Partition Networking #807
Conversation
4cef03f
to
9287e43
Compare
f07bc30
to
9e5cee7
Compare
9bcba1f
to
2ee9dc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing work ashwin!!! the acceptance test was literally self documenting for how to set up cross partition service comms, and incredibly thorough for everything it checks.
efaa483
to
c972097
Compare
- This PR does not include acceptance tests. The desired acceptance tests will be determined based on the expected behavior of ServiceExports when partitions are disabled. - Similarly, controller tests have not been added as our existing controller tests only account for namespace. The behavior with partitions has not been resolved.
c972097
to
6c5cc48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeahhh this is awesome!
* Drop support for Helm 2
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: