Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use component label everywhere #840

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Use component label everywhere #840

merged 2 commits into from
Nov 10, 2021

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Nov 4, 2021

Also add a test to ensure every file has it.

Fixes #673

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

Also add a test to ensure every file has it.
@lkysow lkysow force-pushed the lkysow/component-labels branch from f25e4a6 to 2e68b75 Compare November 4, 2021 21:10
@lkysow lkysow requested review from a team, ishustava and sadjamz and removed request for a team November 4, 2021 21:25
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@@ -9,7 +9,7 @@ metadata:
chart: {{ template "consul.chart" . }}
heritage: {{ .Release.Service }}
release: {{ .Release.Name }}
component: controller
component: connect-injector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

cd `chart_dir`
# Grep for files that don't have 'component: ' in them
local actual=$(grep -L 'component: ' templates/*.yaml | tee /dev/stderr )
[ "${actual}" = '' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! that good ol' grep test 😄

@david-yu david-yu self-requested a review November 9, 2021 04:38
Copy link
Contributor

@david-yu david-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lkysow lkysow merged commit 4f783fe into main Nov 10, 2021
@lkysow lkysow deleted the lkysow/component-labels branch November 10, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm:Add component label to missing files
3 participants