Support PKCS1 and PKCS8 private keys #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For server ca cert
lkysow
force-pushed
the
lkysow/tls-certs
branch
from
3010ad2 to
ce9c4c7
Compare
lkysow
requested review from
a team,
kschoche and
sadjamz
and removed request for
a team
kschoche
reviewed
Nov 5, 2021
| -----END RSA PRIVATE KEY-----` | ||
|
|
||
| // caKeyPKCS8 is caKeyRSA converted to PKCS8 form. | ||
| caKeyPKCS8 string = `-----BEGIN PRIVATE KEY----- |
There was a problem hiding this comment.
I cant wait to get daily emails from dependabot on these :D
kschoche
approved these changes
Nov 5, 2021
ishustava
approved these changes
Nov 5, 2021
lkysow
force-pushed
the
lkysow/tls-certs
branch
from
ce9c4c7 to
8bd61c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For server ca cert
Fixes #575
Checklist: