Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include pod name as tag for connect svcs #848

Closed
wants to merge 1 commit into from
Closed

Include pod name as tag for connect svcs #848

wants to merge 1 commit into from

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Nov 8, 2021

This will allow Consul DNS tag lookups, e.g.
pod-name.service.dc1.consul.

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@lkysow
Include pod name as tag for connect svcs
f7a4bfd 
This will allow Consul DNS tag lookups, e.g.
`pod-name.service.dc1.consul`.
@lkysow lkysow force-pushed the lkysow/connect-tag branch from acb4729 to f7a4bfd Compare November 8, 2021 19:03
@lkysow
Copy link
Member Author

lkysow commented Jan 10, 2022

Closed by #931

@lkysow lkysow closed this Jan 10, 2022
@lkysow lkysow deleted the lkysow/connect-tag branch January 10, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lkysow