Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update consul version to 1.10.4 #861

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Update consul version to 1.10.4 #861

merged 4 commits into from
Nov 15, 2021

Conversation

ishustava
Copy link
Contributor

Changes proposed in this PR:

  • Update consul version

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@ishustava ishustava requested review from a team, lkysow and thisisnotashwin and removed request for a team November 15, 2021 17:16
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@@ -85,7 +85,7 @@ global:
# image: "hashicorp/consul-enterprise:1.10.0-ent"
# ```
# @default: hashicorp/consul:<latest version>
image: "hashicorp/consul:1.10.3"
image: "hashicorp/consul:1.10.4"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! I think I forgot to update consul version in chart.yaml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assumed we would do that when we do the next release release 😅

Copy link
Contributor

@t-eckert t-eckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishustava ishustava merged commit a0af34e into main Nov 15, 2021
@ishustava ishustava deleted the ishustava-patch-1 branch November 15, 2021 19:57
rrondeau pushed a commit to rrondeau/consul-k8s that referenced this pull request Dec 21, 2021
…p#861)

* Enable webhook-cert-manager whenever either controller or connectInject is enabled
* Remove connectInject.certs values. This behavior was already broken, and we don't want to support it going forward with webhook-cert-manager.

Co-authored-by: Iryna Shustava <iryna@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants