Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CRDs #863

Merged
merged 5 commits into from
Nov 16, 2021
Merged

Update CRDs #863

merged 5 commits into from
Nov 16, 2021

Conversation

thisisnotashwin
Copy link
Contributor

@thisisnotashwin thisisnotashwin commented Nov 16, 2021 •
edited
Loading

Changes proposed in this PR:

How I've tested this PR:

  • Unit tests.
  • Creating these resources against latest Consul Enterprise binary.

How I expect reviewers to test this PR:

  • Code review.

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@thisisnotashwin thisisnotashwin requested review from a team, kschoche and ishustava and removed request for a team November 16, 2021 15:51
kschoche
kschoche approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@thisisnotashwin thisisnotashwin merged commit 75236bc into main Nov 16, 2021
@thisisnotashwin thisisnotashwin deleted the update-crds branch November 16, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishustava ishustava ishustava approved these changes

@kschoche kschoche kschoche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisisnotashwin @kschoche @ishustava