made timing based tests a bit more lenient

They were failing to often in CircleCI.
hashicorp · Feb 4, 2022 · 2bf43d8 · 2bf43d8
1 parent f9dd3bb
commit 2bf43d8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/dependency/vault_common_test.go b/dependency/vault_common_test.go
@@ -20,8 +20,8 @@ func TestVaultRenewDuration(t *testing.T) {
 
 	nonRenewable := Secret{LeaseDuration: 100}
 	nonRenewableDur := leaseCheckWait(&nonRenewable).Seconds()
-	if nonRenewableDur < 85 || nonRenewableDur > 95 {
-		t.Fatalf("renewable duration is not within 85%% to 95%% of lease duration: %f", nonRenewableDur)
+	if nonRenewableDur < 80 || nonRenewableDur > 95 {
+		t.Fatalf("renewable duration is not within 80%% to 95%% of lease duration: %f", nonRenewableDur)
 	}
 
 	var data = map[string]interface{}{
@@ -60,8 +60,8 @@ func TestVaultRenewDuration(t *testing.T) {
 
 	nonRenewableCert := Secret{LeaseDuration: 100, Data: data}
 	nonRenewableCertDur := leaseCheckWait(&nonRenewableCert).Seconds()
-	if nonRenewableCertDur < 85 || nonRenewableCertDur > 95 {
-		t.Fatalf("non renewable certificate duration is not within 85%% to 95%%: %f", nonRenewableCertDur)
+	if nonRenewableCertDur < 80 || nonRenewableCertDur > 95 {
+		t.Fatalf("non renewable certificate duration is not within 80%% to 95%%: %f", nonRenewableCertDur)
 	}
 
 	t.Run("secret ID handling", func(t *testing.T) {
@@ -75,8 +75,8 @@ func TestVaultRenewDuration(t *testing.T) {
 			nonRenewableSecretID := Secret{LeaseDuration: 100, Data: data}
 			nonRenewableSecretIDDur := leaseCheckWait(&nonRenewableSecretID).Seconds()
 
-			if nonRenewableSecretIDDur < 0.85*(60+1) || nonRenewableSecretIDDur > 0.95*(60+1) {
-				t.Fatalf("renewable duration is not within 85%% to 95%% of lease duration: %f", nonRenewableSecretIDDur)
+			if nonRenewableSecretIDDur < 0.80*(60+1) || nonRenewableSecretIDDur > 0.95*(60+1) {
+				t.Fatalf("renewable duration is not within 80%% to 95%% of lease duration: %f", nonRenewableSecretIDDur)
 			}
 		})
 
@@ -91,8 +91,8 @@ func TestVaultRenewDuration(t *testing.T) {
 			nonRenewableSecretID := Secret{LeaseDuration: leaseDuration, Data: data}
 			nonRenewableSecretIDDur := leaseCheckWait(&nonRenewableSecretID).Seconds()
 
-			if nonRenewableSecretIDDur < 0.85*(leaseDuration+1) || nonRenewableSecretIDDur > 0.95*(leaseDuration+1) {
-				t.Fatalf("renewable duration is not within 85%% to 95%% of lease duration: %f", nonRenewableSecretIDDur)
+			if nonRenewableSecretIDDur < 0.80*(leaseDuration+1) || nonRenewableSecretIDDur > 0.95*(leaseDuration+1) {
+				t.Fatalf("renewable duration is not within 80%% to 95%% of lease duration: %f", nonRenewableSecretIDDur)
 			}
 		})
 
@@ -106,8 +106,8 @@ func TestVaultRenewDuration(t *testing.T) {
 			nonRenewableSecretID := Secret{LeaseDuration: leaseDuration, Data: data}
 			nonRenewableSecretIDDur := leaseCheckWait(&nonRenewableSecretID).Seconds()
 
-			if nonRenewableSecretIDDur < 0.85*(leaseDuration+1) || nonRenewableSecretIDDur > 0.95*(leaseDuration+1) {
-				t.Fatalf("renewable duration is not within 85%% to 95%% of lease duration: %f", nonRenewableSecretIDDur)
+			if nonRenewableSecretIDDur < 0.80*(leaseDuration+1) || nonRenewableSecretIDDur > 0.95*(leaseDuration+1) {
+				t.Fatalf("renewable duration is not within 80%% to 95%% of lease duration: %f", nonRenewableSecretIDDur)
 			}
 		})
 

diff --git a/manager/dedup_test.go b/manager/dedup_test.go
@@ -40,7 +40,7 @@ func TestDedup_IsLeader(t *testing.T) {
 	// Wait until we are leader
 	select {
 	case <-dedup.UpdateCh():
-	case <-time.After(3 * time.Second):
+	case <-time.After(4 * time.Second):
 		t.Fatalf("timeout")
 	}