Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll back Arm GCC build #1404

Closed
eikenb opened this issue Aug 14, 2020 · 1 comment · Fixed by #1471
Closed

Roll back Arm GCC build #1404

eikenb opened this issue Aug 14, 2020 · 1 comment · Fixed by #1471
Labels
enhancement good first issue
Milestone
0.26.0

Comments

@eikenb
Copy link
Contributor

eikenb commented Aug 14, 2020

We were using CGO with our ARM builds due to this bug... golang/go#32912

Which was fixed in go1.14. So we can remove this workaround.

The workaround was initially implemented here.. d1e1dad

Just need to remove the special cases for ARM.
@faizansiddiqu007
Copy link

just remove them straight

TheTweak pushed a commit to TheTweak/consul-template that referenced this issue May 19, 2021
Removed special cases for ARM build in Makefile fixes hashicorp#1404
a077415
@TheTweak TheTweak mentioned this issue May 19, 2021
Merged
eikenb pushed a commit that referenced this issue May 21, 2021
@eikenb
Removed special cases for ARM build in Makefile fixes #1404
e4e4acf
@eikenb eikenb added this to the 0.26.0 milestone Jun 9, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
0.26.0
Development

Successfully merging a pull request may close this issue.

Removed special cases for ARM build in Makefile fixes #1404 TheTweak/consul-template
2 participants
@eikenb @faizansiddiqu007