dependency: fix kv2 data path prefix checking #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikenb
reviewed
Feb 28, 2020
dependency/vault_common.go
Outdated
| @@ -333,14 +333,15 @@ func isKVv2(client *api.Client, path string) (string, bool, error) { | |||
| return mountPath, false, nil | |||
| } | |||
|
|
|||
| func addPrefixToVKVPath(p, mountPath, apiPrefix string) string { | |||
| func addPrefixToVKVPath(p, mountPath, apiPrefixRaw string) string { | |||
| apiPrefix := path.Clean(apiPrefixRaw) | |||
There was a problem hiding this comment.
Why Clean() here? The KV prefixes have a path like structure, they don't follow all the rules. Seems like it might have some unintended side effect.
There was a problem hiding this comment.
Thanks for the context on the prefix structure and good point, updated changes to make it more explicit on the trailing / check
findkim
force-pushed
the
fix-kv2-secret-path
branch
from
feaa7b8
to
8d0ec8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implicit
/data/path prefix for kv2 secrets were not properly prepended for secret paths matching/data*.Fixes #1340