Change whitelist/blacklist to allowlist/denylist #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates project to use inclusive language while keeping backward compatibility for the changed configuration option names.
Fields are still exported to be loaded by mapstructure but ignored by JSON encoding.
eikenb
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
Except for the one change to the case this all looks really good. I like how you handled backwards compatibility with the *deprecated names to minimize the occurrences of the old terminology.
I'm going to go ahead and approve this as there is only one very minor change.
mapstructure decoder seems to be case insensitive, but updating the test anyway to be consistent
findkim
added a commit
that referenced
this pull request
Jul 27, 2020
Removing changelog line to match the revert of GH-1388
eikenb
pushed a commit
that referenced
this pull request
Apr 23, 2021
PR #1388 already changed whitelist/blacklist to allowlist/denylist, but the example in the configuration documentation was left out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Consul Template to use inclusive language while keeping backward compatibility for the changed configuration option names. Configuration documentation, inline documentation, and variable names are updated to have minimal occurrences of the renamed values.
template.function_blacklistis renamed totemplate.function_denylistexec.env.blacklistis renamed toexec.env.denylistexec.env.whitelistis renamed toexec.env.allowlistWe encourage practitioners to update their configuration to match these changes, but existing configurations are still backward compatibile.
Resolves #1387