Allow setting user/group ownership of template output

[deblasis]

Adds support for the uid and gid entries in the template stanza that would ultimately be passed to a os.Chown command.

It obviously works only on POSIX and Windows is handled with graceful noop with a warning if the user set uid or gid

Related issues #639, #1497, #1185 and also nomad/5020

Signed-off-by: Alessandro De Blasis alex@deblasis.net

[eikenb]

Looks like a problem with the Windows build and the CI system doesn't like the Chown call, might be a mount time restriction on the /tmp directory. Maybe try using a local directory for it instead?

[deblasis]

Hi @eikenb, I covered more cases and changed things a bit. It should work now.
I didn't switch to a local directory because I see that /tmp is used extensively without issues and I think I found the bug elsewhere.
Let's see if Miss CI is happy about it 😄

[lukas-w]

I also did some work on this issue recently but didn't find the time to open a PR yet unfortunately (no tests yet). My implementation supports setting a file owner/group and permission bits (converts octal permissions to ACL entries) on Windows as well. See master...lukas-w:f-file-owner. Maybe we can join efforts on this?

[3nprob]

@eikenb Did you get to take another look at this after the CI issues were addressed? For being able to use separate uids for different tasks, this is crucial.

While it would be sweet to get Windows support as per @lukas-w , isn't *nix/mac independently worthwhile enough to push through?

[eikenb]

Thanks for the prompt @3nprob, I'll take another look at this when I start work on 0.28.0 (should be soon, next in my project queue).

[eikenb]

Everything looks good. Thanks!

[lukas-w]

While it would be sweet to get Windows support as per @lukas-w , isn't *nix/mac independently worthwhile enough to push through?

Sure, It's great to see this merged! Another difference in the two implementations though is that mine supports specifying user and group entries as string so you can pass uid/gid as well as user/group names which I find more useful personally because it allows for more readable configurations and facilitates Windows support (even if it's not implemented now) as Windows doesn't use integer identifiers. I can prepare a PR for this soon if that's something that's desired as to avoid a future interface change in Nomad & consul-template.

[eikenb]

Hey @lukas-w,

If you'd like to open a PR I'll be happy to review it.