Support for setting Vault CA from VAULT_CACERT_BYTES env #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhjp
requested review from
roncodingenthusiast
and removed request for
a team
VioletHynes
approved these changes
Aug 2, 2023
|
Thanks both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to set the CA we should trust when communicating with Vault over TLS through a VAULT_CACERT_BYTES environment variable.
The Vault API package supports this since hashicorp/vault#14753
However, without support in consul-template, we end up with weird compatibility. Vault Agent automatically supports consuming that environment variable through the API package for its auto-auth feature, but consul-template reads in TLS configuration differently so Vault Agent's templating doesn't currently work with VAULT_CACERT_BYTES.
See hashicorp/vault-k8s#507 for an example of attempting to use VAULT_CACERT_BYTES in the Agent Injector.