Default to tcp protocol when workload protocol is unspecified (#18824)

hashicorp · Sep 15, 2023 · 6838441 · 6838441
1 parent 850fbda
commit 6838441
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/mesh/internal/controllers/sidecarproxy/builder/local_app.go b/internal/mesh/internal/controllers/sidecarproxy/builder/local_app.go
@@ -243,7 +243,7 @@ func (l *ListenerBuilder) addInboundRouter(clusterName string, port *pbcatalog.W
 		return l
 	}
 
-	if port.Protocol == pbcatalog.Protocol_PROTOCOL_TCP {
+	if port.Protocol == pbcatalog.Protocol_PROTOCOL_TCP || port.Protocol == pbcatalog.Protocol_PROTOCOL_UNSPECIFIED {
 		r := &pbproxystate.Router{
 			Destination: &pbproxystate.Router_L4{
 				L4: &pbproxystate.L4Destination{

diff --git a/internal/mesh/internal/mappers/sidecarproxymapper/service_mapper.go b/internal/mesh/internal/mappers/sidecarproxymapper/service_mapper.go
@@ -24,7 +24,7 @@ func (m *Mapper) MapServiceToProxyStateTemplate(ctx context.Context, rt controll
 	return controller.MakeRequests(types.ProxyStateTemplateType, ids), nil
 }
 
-// mapServiceThroughDestinationsToProxyStateTemplates takes and explicit
+// mapServiceThroughDestinationsToProxyStateTemplates takes an explicit
 // Service and traverses back through Destinations to Workloads to
 // ProxyStateTemplates.
 //