NET-4774 - replace usage of deprecated Envoy field match_subject_alt_names #19954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmurret
added
backport/1.15
jmurret
force-pushed
the
jm/NET-4774
branch
4 times, most recently
from
b45a64c to
b1e93af
Compare
jmurret
changed the title
jmurret
force-pushed
the
jm/NET-4774
branch
5 times, most recently
from
0196da8 to
6f86e3d
Compare
zalimeni
approved these changes
Dec 22, 2023
Makefile
Outdated
| ENVOY_VERSION?='1.28.0' | ||
| ENVOY_VERSION?='1.25.4' |
There was a problem hiding this comment.
Guessing this is accidental diff from your other recent PR?
jmurret
force-pushed
the
jm/NET-4774
branch
2 times, most recently
from
6b3fe3b to
6461f90
Compare
This was referenced Dec 22, 2023
jmurret
added a commit
that referenced
this pull request
Jan 2, 2024
jmurret
added a commit
that referenced
this pull request
Jan 2, 2024
jmurret
added a commit
that referenced
this pull request
Jan 2, 2024
jmurret
added a commit
that referenced
this pull request
Jan 2, 2024
jmurret
added a commit
that referenced
this pull request
Jan 2, 2024
jmurret
added a commit
that referenced
this pull request
Jan 2, 2024
jmurret
added a commit
that referenced
this pull request
Jan 2, 2024
hashi-derek
added a commit
that referenced
this pull request
Jan 31, 2024
Fixes issue: #20360 A regression was introduced in #19954 where the SAN validation matching was reduced from 4 potential types down to just the URI. Terminating gateways will need to match on many fields depending on user configuration, since they make egress calls outside of the cluster. Having more than one matcher behaves like an OR operation, where any match is sufficient to pass the certificate validation. To maintain backwards compatibility with the old untyped `match_subject_alt_names` Envoy behavior, we should match on all 4 enum types. https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/transport_sockets/tls/v3/common.proto#enum-extensions-transport-sockets-tls-v3-subjectaltnamematcher-santype
hashi-derek
added a commit
that referenced
this pull request
Jan 31, 2024
Fixes issue: #20360 A regression was introduced in #19954 where the SAN validation matching was reduced from 4 potential types down to just the URI. Terminating gateways will need to match on many fields depending on user configuration, since they make egress calls outside of the cluster. Having more than one matcher behaves like an OR operation, where any match is sufficient to pass the certificate validation. To maintain backwards compatibility with the old untyped `match_subject_alt_names` Envoy behavior, we should match on all 4 enum types. https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/transport_sockets/tls/v3/common.proto#enum-extensions-transport-sockets-tls-v3-subjectaltnamematcher-santype
hashi-derek
added a commit
that referenced
this pull request
Jan 31, 2024
Fixes issue: #20360 A regression was introduced in #19954 where the SAN validation matching was reduced from 4 potential types down to just the URI. Terminating gateways will need to match on many fields depending on user configuration, since they make egress calls outside of the cluster. Having more than one matcher behaves like an OR operation, where any match is sufficient to pass the certificate validation. To maintain backwards compatibility with the old untyped `match_subject_alt_names` Envoy behavior, we should match on all 4 enum types. https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/transport_sockets/tls/v3/common.proto#enum-extensions-transport-sockets-tls-v3-subjectaltnamematcher-santype
hashi-derek
added a commit
that referenced
this pull request
Jan 31, 2024
Fixes issue: #20360 A regression was introduced in #19954 where the SAN validation matching was reduced from 4 potential types down to just the URI. Terminating gateways will need to match on many fields depending on user configuration, since they make egress calls outside of the cluster. Having more than one matcher behaves like an OR operation, where any match is sufficient to pass the certificate validation. To maintain backwards compatibility with the old untyped `match_subject_alt_names` Envoy behavior, we should match on all 4 enum types. https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/transport_sockets/tls/v3/common.proto#enum-extensions-transport-sockets-tls-v3-subjectaltnamematcher-santype
This was referenced Jan 31, 2024
hashi-derek
added a commit
that referenced
this pull request
Jan 31, 2024
Fixes issue: #20360 A regression was introduced in #19954 where the SAN validation matching was reduced from 4 potential types down to just the URI. Terminating gateways will need to match on many fields depending on user configuration, since they make egress calls outside of the cluster. Having more than one matcher behaves like an OR operation, where any match is sufficient to pass the certificate validation. To maintain backwards compatibility with the old untyped `match_subject_alt_names` Envoy behavior, we should match on all 4 enum types. https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/transport_sockets/tls/v3/common.proto#enum-extensions-transport-sockets-tls-v3-subjectaltnamematcher-santype
hashi-derek
added a commit
that referenced
this pull request
Jan 31, 2024
Fixes issue: #20360 A regression was introduced in #19954 where the SAN validation matching was reduced from 4 potential types down to just the URI. Terminating gateways will need to match on many fields depending on user configuration, since they make egress calls outside of the cluster. Having more than one matcher behaves like an OR operation, where any match is sufficient to pass the certificate validation. To maintain backwards compatibility with the old untyped `match_subject_alt_names` Envoy behavior, we should match on all 4 enum types. https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/transport_sockets/tls/v3/common.proto#enum-extensions-transport-sockets-tls-v3-subjectaltnamematcher-santype
hashi-derek
added a commit
that referenced
this pull request
Jan 31, 2024
…6.x (#20418) Fix SAN matching on terminating gateways (#20417) Fixes issue: #20360 A regression was introduced in #19954 where the SAN validation matching was reduced from 4 potential types down to just the URI. Terminating gateways will need to match on many fields depending on user configuration, since they make egress calls outside of the cluster. Having more than one matcher behaves like an OR operation, where any match is sufficient to pass the certificate validation. To maintain backwards compatibility with the old untyped `match_subject_alt_names` Envoy behavior, we should match on all 4 enum types. https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/transport_sockets/tls/v3/common.proto#enum-extensions-transport-sockets-tls-v3-subjectaltnamematcher-santype Co-authored-by: Derek Menteer <105233703+hashi-derek@users.noreply.github.com>
hashi-derek
added a commit
that referenced
this pull request
Jan 31, 2024
…7.x (#20419) Fix SAN matching on terminating gateways (#20417) Fixes issue: #20360 A regression was introduced in #19954 where the SAN validation matching was reduced from 4 potential types down to just the URI. Terminating gateways will need to match on many fields depending on user configuration, since they make egress calls outside of the cluster. Having more than one matcher behaves like an OR operation, where any match is sufficient to pass the certificate validation. To maintain backwards compatibility with the old untyped `match_subject_alt_names` Envoy behavior, we should match on all 4 enum types. https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/transport_sockets/tls/v3/common.proto#enum-extensions-transport-sockets-tls-v3-subjectaltnamematcher-santype Co-authored-by: Derek Menteer <105233703+hashi-derek@users.noreply.github.com>
This was referenced Sep 27, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
match_subject_alt_nameshas been available since at least envoy 1.20Testing & Reproduction steps
Links
PR Checklist