Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of NET-4774 - replace usage of deprecated Envoy field match_subject_alt_names into release/1.17.x #20057

Merged

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19954 to be assessed for backporting due to the inclusion of the label backport/1.17.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@jmurret
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

match_subject_alt_names has been available since at least envoy 1.20

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 22, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@jmurret jmurret force-pushed the backport/jm/NET-4774/implicitly-tops-unicorn branch 3 times, most recently from 19b37a6 to 5aca018 Compare January 2, 2024 18:02
@jmurret jmurret marked this pull request as ready for review January 2, 2024 18:02
@jmurret jmurret enabled auto-merge (squash) January 2, 2024 18:03
@jmurret jmurret force-pushed the backport/jm/NET-4774/implicitly-tops-unicorn branch from 5aca018 to 1fd8ed3 Compare January 2, 2024 18:31
@jmurret jmurret force-pushed the backport/jm/NET-4774/implicitly-tops-unicorn branch from 1fd8ed3 to e87f903 Compare January 2, 2024 18:31
@jmurret jmurret merged commit 833f3e2 into release/1.17.x Jan 2, 2024
94 checks passed
@jmurret jmurret deleted the backport/jm/NET-4774/implicitly-tops-unicorn branch January 2, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants